-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-125206: Correct detection of complex numbers support in libffi #126104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
skirpichev
commented
Oct 29, 2024
•
edited by bedevere-app
bot
Loading
edited by bedevere-app
bot
- Issue: CTypes test failed, complex double problem #125206
!buildbot SPARCv9 Oracle Solaris 11.4 |
🤖 New build scheduled with the buildbot fleet by @skirpichev for commit 66c1cf7 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
!buildbot PPC64LE CentOS9 LTO + PGO |
🤖 New build scheduled with the buildbot fleet by @skirpichev for commit 66c1cf7 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
PPC64LE build works as expected (no support) |
!buildbot SPARCv9 Oracle Solaris 11.4 |
🤖 New build scheduled with the buildbot fleet by @skirpichev for commit fc4ebff 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
Hmm, now on SPARCv9 - libffi support was detected. Test failures seems unrelated and build was successful. (C.f. https://buildbot.python.org/all/#/builders/1262/builds/13 and https://buildbot.python.org/#/builders/1262/builds/21) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@efimov-mikhail: Can you test the fix on Debian 10?
I don't expect something new, as on his local system patch was working: #125322 (comment) (test code was unchanged) |
Yes, I can. It looks like the correct fix, but it's better to test again. |
This fix works fine on Debian 10. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (if the Sparc failure is unrelated).
Merged, thanks.
There are tons of unrelated errors/test failures on Solaris. |
On SPARCv9 only configure test was checked. It reports "yes" (supported). But it seems that ctypes tests weren't run. Sadly that configure script doesn't report library versions (even if this is available e.g. with |
We could fix that if we wanted. |
If that does make sense, I can open an issue. But I admit, that I don't know how to solve this in general: maybe every snowflake^Wlibrary will require a special treatment. BTW, version information is unavailable in the config.log (even for versioned checks like for libmpdec). |
IIRC (from the top of my head), the pkg-config macro will print version information if you specify version bounds (see the sqlite3 third-party detection code in |
Quick test for mpdec (which uses same PKG_CHECK_MODULES macro for system libmpdec, just as for sqlite3) shows, that it's not true:
|